Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(profiles): Pass homeDir, projectDir when creating ProfileInfo instance #3169

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(profiles): Pass homeDir, projectDir when creating ProfileInfo instance #3169

wants to merge 6 commits into from

Conversation

traeok
Copy link
Member

@traeok traeok commented Oct 2, 2024 •
edited
Loading

Proposed changes

Fixed a bug where a new ProfileInfo instance was being created when initializing Zowe profiles, but that instance was missing the homeDir and projectDir from its constructor options.

Release Notes

Milestone: 3.0.1

Changelog:

  • Fixed an issue where Zowe Explorer displayed a "No Zowe client configurations" prompt when a project user configuration existed but no global configuration was present. #3168
  • Fixed an issue where the ProfilesUtils.getProfileInfo function returned a new ProfileInfo instance that ignored the ZOWE_CLI_HOME environment variable and workspace paths. #3168

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here): v2-lts

@traeok traeok changed the title fix(profiles): Pass homeDir and projectDir when creating ProfileInfo instance fix(profiles): Pass homeDir, projectDir when creating ProfileInfo instance Oct 2, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.81%. Comparing base (77235a3) to head (e86d394).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3169      +/-   ##
==========================================
+ Coverage   92.79%   92.81%   +0.01%     
==========================================
  Files         113      113              
  Lines       11670    11672       +2     
  Branches     2603     2609       +6     
==========================================
+ Hits        10829    10833       +4     
+ Misses        839      837       -2     
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@traeok traeok marked this pull request as ready for review October 2, 2024 18:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

📅 Suggested merge-by date: 10/16/2024

@t1m0thyj t1m0thyj added this to the v3.0.1 milestone Oct 2, 2024
@t1m0thyj t1m0thyj linked an issue Oct 2, 2024 that may be closed by this pull request
Zowe Explorer v3.0.0 continually prompts on startup if global-scope config does not exist #3168
Open
zFernand0
zFernand0 previously approved these changes Oct 3, 2024
View reviewed changes
anaxceron
anaxceron reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple comments re: changelog.

packages/zowe-explorer/CHANGELOG.md Outdated Show resolved Hide resolved
packages/zowe-explorer/CHANGELOG.md Outdated Show resolved Hide resolved
@adam-wolfe adam-wolfe mentioned this pull request Oct 3, 2024
Open
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

t1m0thyj
t1m0thyj approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @traeok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t1m0thyj t1m0thyj t1m0thyj approved these changes

@JillieBeanSim JillieBeanSim Awaiting requested review from JillieBeanSim

@awharn awharn Awaiting requested review from awharn

@rudyflores rudyflores Awaiting requested review from rudyflores

@adam-wolfe adam-wolfe Awaiting requested review from adam-wolfe

@SanthoshiBoyina1 SanthoshiBoyina1 Awaiting requested review from SanthoshiBoyina1

@likhithanimma1 likhithanimma1 Awaiting requested review from likhithanimma1

@zFernand0 zFernand0 Awaiting requested review from zFernand0

@anaxceron anaxceron Awaiting requested review from anaxceron

At least 2 approving reviews are required to merge this pull request.

Assignees

@traeok traeok

Labels
size/S
Projects
Zowe Explorer for VS Code
Status: Review/QA
Milestone
v3.0.1
Development

Successfully merging this pull request may close these issues.

Zowe Explorer v3.0.0 continually prompts on startup if global-scope config does not exist
4 participants
@traeok @t1m0thyj @zFernand0 @anaxceron